Hello Laurent,
Thank you for your feedback!
> From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx <linux-renesas-soc-owner@xxxxxxxxxxxxxxx> On Behalf Of Laurent Pinchart
> Sent: 15 August 2019 13:03
> Subject: Re: [PATCH v2 5/9] drm/panel: Add timings field to drm_panel
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Thu, Aug 15, 2019 at 12:04:29PM +0100, Fabrizio Castro wrote:
> > We need to know if the panel supports dual-link, similarly
> > to bridges, therefore add a reference to drm_timings in
> > drm_panel.
>
> Panels may also need to report setup/hold time, so it's not about
> dual-link only. I would make this explicit in the commit message.
Ok
>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> >
> > ---
> > v1->v2:
> > * new patch
> >
> > include/drm/drm_panel.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> > index 8c738c0..cd6ff07 100644
> > --- a/include/drm/drm_panel.h
> > +++ b/include/drm/drm_panel.h
> > @@ -26,6 +26,7 @@
> >
> > #include <linux/errno.h>
> > #include <linux/list.h>
> > +#include <drm/drm_timings.h>
>
> You can just add a forward-declaration of struct drm_timing.
Ok
Thanks,
Fab
>
> >
> > struct device_node;
> > struct drm_connector;
> > @@ -81,6 +82,7 @@ struct drm_panel_funcs {
> > * struct drm_panel - DRM panel object
> > * @drm: DRM device owning the panel
> > * @connector: DRM connector that the panel is attached to
> > + * @timings: timing information
> > * @dev: parent device of the panel
> > * @link: link from panel device (supplier) to DRM device (consumer)
> > * @funcs: operations that can be performed on the panel
> > @@ -89,6 +91,7 @@ struct drm_panel_funcs {
> > struct drm_panel {
> > struct drm_device *drm;
> > struct drm_connector *connector;
> > + const struct drm_timings *timings;
> > struct device *dev;
> >
> > const struct drm_panel_funcs *funcs;
>
> --
> Regards,
>
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
