On Sun, Aug 04, 2019 at 08:55:51AM +0200, Sam Ravnborg wrote: > Drop the deprecated drmP.h header file, and trim msm_drv.h > to the relevant include files. > > This resulted in a suprisingly many edits as many files relied > on headers included via msm_drv.h. > But msm_drv.h is not supposed to carry include files it do not need, so > the individual files have to include what extra they needs. > > v2: > - Rebased on top of https://gitlab.freedesktop.org/drm/msm.git msm-next > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Acked-by: Sean Paul <sean@xxxxxxxxxx> > Cc: Rob Clark <robdclark@xxxxxxxxx> > Cc: Sean Paul <sean@xxxxxxxxxx> > Cc: David Airlie <airlied@xxxxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx> > Cc: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> > Cc: Jeykumar Sankaran <jsanka@xxxxxxxxxxxxxx> > Cc: Bruce Wang <bzwang@xxxxxxxxxxxx> > Cc: Shayenne Moura <shayenneluzmoura@xxxxxxxxx> > Cc: Mamta Shukla <mamtashukla555@xxxxxxxxx> > Cc: Jonathan Marek <jonathan@xxxxxxxx> > Cc: Carsten Behling <carsten.behling@xxxxxxxxxxxxxx> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxx> > Cc: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> > Cc: Sibi Sankar <sibis@xxxxxxxxxxxxxx> > Cc: Todor Tomov <todor.tomov@xxxxxxxxxx> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx > --- > drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +++- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +++++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 - > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 ++++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 1 + > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + > drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 1 + > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 3 +++ > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 2 ++ > drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 2 ++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 3 +++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 1 + > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 ++++++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 2 ++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 1 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 8 +++++--- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 ++ > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 2 ++ > drivers/gpu/drm/msm/dsi/pll/dsi_pll.h | 2 +- > drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 ++ > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 1 + > drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 1 + > drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c | 2 ++ > drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 2 ++ > drivers/gpu/drm/msm/msm_atomic.c | 1 + > drivers/gpu/drm/msm/msm_debugfs.c | 5 +++++ > drivers/gpu/drm/msm/msm_drv.c | 10 +++++++++- > drivers/gpu/drm/msm/msm_drv.h | 1 - > drivers/gpu/drm/msm/msm_fb.c | 2 ++ > drivers/gpu/drm/msm/msm_fbdev.c | 1 + > drivers/gpu/drm/msm/msm_gem.c | 2 ++ > drivers/gpu/drm/msm/msm_gem_prime.c | 6 ++++-- > drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++++ > drivers/gpu/drm/msm/msm_gpummu.c | 2 ++ > drivers/gpu/drm/msm/msm_perf.c | 3 +++ > drivers/gpu/drm/msm/msm_rd.c | 7 +++++-- > drivers/gpu/drm/msm/msm_submitqueue.c | 2 ++ > 40 files changed, 99 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c b/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c > index 9f2dd76bd67a..075ecce4b5e0 100644 > --- a/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c > +++ b/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c > @@ -2,9 +2,11 @@ > /* Copyright (c) 2016-2017 The Linux Foundation. All rights reserved. > */ > > - > #include <linux/types.h> > #include <linux/debugfs.h> > + > +#include <drm/drm_debugfs.h> > +#include <drm/drm_file.h> > #include <drm/drm_print.h> > > #include "a5xx_gpu.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 40ea6286eac1..db6c9ccf3be2 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -20,11 +20,13 @@ > #include <linux/sort.h> > #include <linux/debugfs.h> > #include <linux/ktime.h> > + > #include <drm/drm_crtc.h> > #include <drm/drm_flip_work.h> > #include <drm/drm_mode.h> > #include <drm/drm_probe_helper.h> > #include <drm/drm_rect.h> > +#include <drm/drm_vblank.h> > > #include "dpu_kms.h" > #include "dpu_hw_lm.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 1cf4e306fccf..445389065417 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -17,14 +17,16 @@ > */ > > #define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__ > -#include <linux/kthread.h> > #include <linux/debugfs.h> > +#include <linux/kthread.h> > #include <linux/seq_file.h> > > -#include "msm_drv.h" > -#include "dpu_kms.h" > #include <drm/drm_crtc.h> > +#include <drm/drm_file.h> > #include <drm/drm_probe_helper.h> > + > +#include "msm_drv.h" > +#include "dpu_kms.h" > #include "dpu_hwio.h" > #include "dpu_hw_catalog.h" > #include "dpu_hw_intf.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > index 90f439812088..ec76b8687a98 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > @@ -9,7 +9,6 @@ > #include <linux/bug.h> > #include <linux/bitmap.h> > #include <linux/err.h> > -#include <drm/drmP.h> > > /** > * Max hardware block count: For ex: max 12 SSPP pipes or > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 435b846f9f52..e393a423d7d7 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -18,10 +18,12 @@ > > #define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__ > > -#include <drm/drm_crtc.h> > #include <linux/debugfs.h> > -#include <linux/of_irq.h> > #include <linux/dma-buf.h> > +#include <linux/of_irq.h> > + > +#include <drm/drm_crtc.h> > +#include <drm/drm_file.h> > > #include "msm_drv.h" > #include "msm_mmu.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > index e9f998344838..f8ec5988302e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > @@ -19,6 +19,8 @@ > #ifndef __DPU_KMS_H__ > #define __DPU_KMS_H__ > > +#include <drm/drm_drv.h> > + > #include "msm_drv.h" > #include "msm_kms.h" > #include "msm_mmu.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > index 1858b40b18d8..cd6e9bb1fedf 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > @@ -21,8 +21,9 @@ > #include <linux/debugfs.h> > #include <linux/dma-buf.h> > > -#include <drm/drm_damage_helper.h> > #include <drm/drm_atomic_uapi.h> > +#include <drm/drm_damage_helper.h> > +#include <drm/drm_file.h> > > #include "msm_drv.h" > #include "dpu_kms.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > index 8bc3aea7cd86..6a30c4fd24da 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > @@ -5,6 +5,7 @@ > #define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__ > > #include <linux/debugfs.h> > +#include <linux/delay.h> > > #include "dpu_vbif.h" > #include "dpu_hw_vbif.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > index 0cfd4c06b610..a8a58ea826d6 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > @@ -19,6 +19,7 @@ > #include <drm/drm_flip_work.h> > #include <drm/drm_mode.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_vblank.h> > > #include "mdp4_kms.h" > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > index b764d7f10312..8b284b2d9489 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > @@ -16,6 +16,7 @@ > */ > > #include <drm/drm_print.h> > +#include <drm/drm_vblank.h> > > #include "msm_drv.h" > #include "mdp4_kms.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > index e437aa806f7b..7e7c03936af0 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > @@ -15,6 +15,9 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/delay.h> > + > +#include <drm/drm_vblank.h> > > #include "msm_drv.h" > #include "msm_gem.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c > index df6f9803a1d7..f6062fe15bd0 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c > @@ -16,6 +16,8 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/delay.h> > + > #include <drm/drm_crtc.h> > #include <drm/drm_probe_helper.h> > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c > index 2d46d1126283..d8c2d9e8d575 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c > @@ -16,6 +16,8 @@ > */ > > #include <drm/drm_damage_helper.h> > +#include <drm/drm_fourcc.h> > + > #include "mdp4_kms.h" > > #define DOWN_SCALE_MAX 8 > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > index c3751c95b452..1017246bc3db 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > @@ -17,10 +17,13 @@ > */ > > #include <linux/sort.h> > + > #include <drm/drm_mode.h> > #include <drm/drm_crtc.h> > #include <drm/drm_flip_work.h> > +#include <drm/drm_fourcc.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_vblank.h> > > #include "mdp5_kms.h" > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c > index 280e368bc9bb..a62f9c06d3c1 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c > @@ -18,6 +18,7 @@ > #include <linux/irq.h> > > #include <drm/drm_print.h> > +#include <drm/drm_vblank.h> > > #include "msm_drv.h" > #include "mdp5_kms.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index 1c55401956c4..52ec2977c566 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -16,9 +16,15 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/delay.h> > #include <linux/interconnect.h> > #include <linux/of_irq.h> > > +#include <drm/drm_debugfs.h> > +#include <drm/drm_drv.h> > +#include <drm/drm_file.h> > +#include <drm/drm_vblank.h> > + > #include "msm_drv.h" > #include "msm_gem.h" > #include "msm_mmu.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > index 91609bde033a..61e0eec54f3f 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > @@ -17,7 +17,9 @@ > */ > > #include <drm/drm_damage_helper.h> > +#include <drm/drm_fourcc.h> > #include <drm/drm_print.h> > + > #include "mdp5_kms.h" > > struct mdp5_plane { > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > index 2834837f4d3e..620413f9367f 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > @@ -16,6 +16,7 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <drm/drm_fourcc.h> > #include <drm/drm_util.h> > > #include "mdp5_kms.h" > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index aa35d18ab43c..ab934070f0e1 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -5,19 +5,21 @@ > > #include <linux/clk.h> > #include <linux/delay.h> > +#include <linux/dma-mapping.h> > #include <linux/err.h> > #include <linux/gpio.h> > #include <linux/gpio/consumer.h> > #include <linux/interrupt.h> > +#include <linux/mfd/syscon.h> > #include <linux/of_device.h> > #include <linux/of_gpio.h> > +#include <linux/of_graph.h> > #include <linux/of_irq.h> > #include <linux/pinctrl/consumer.h> > -#include <linux/of_graph.h> > +#include <linux/regmap.h> > #include <linux/regulator/consumer.h> > #include <linux/spinlock.h> > -#include <linux/mfd/syscon.h> > -#include <linux/regmap.h> > + > #include <video/mipi_display.h> > > #include "dsi.h" > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > index c3a61876470f..1594f1422372 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > @@ -3,6 +3,8 @@ > * Copyright (c) 2016, The Linux Foundation. All rights reserved. > */ > > +#include <linux/delay.h> > + > #include "dsi_phy.h" > #include "dsi.xml.h" > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c > index a198f51d47b4..f22583353957 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c > @@ -3,6 +3,8 @@ > * Copyright (c) 2012-2015, The Linux Foundation. All rights reserved. > */ > > +#include <linux/delay.h> > + > #include "dsi_phy.h" > #include "dsi.xml.h" > > diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll.h b/drivers/gpu/drm/msm/dsi/pll/dsi_pll.h > index 118bebe53de3..c6a3623f905d 100644 > --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll.h > +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll.h > @@ -6,8 +6,8 @@ > #ifndef __DSI_PLL_H__ > #define __DSI_PLL_H__ > > -#include <linux/clk.h> > #include <linux/clk-provider.h> > +#include <linux/delay.h> > > #include "dsi.h" > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c > index 03197b8959ba..867691ea7900 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c > @@ -15,6 +15,8 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/delay.h> > + > #include "hdmi.h" > > struct hdmi_bridge { > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > index a6eeab2c4dc3..e3dc4e781558 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > @@ -15,6 +15,7 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/delay.h> > #include <linux/gpio.h> > #include <linux/pinctrl/consumer.h> > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c > index fe82ad38aa7a..a8f3b2cbfdc5 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c > @@ -4,6 +4,7 @@ > */ > > #include <linux/clk-provider.h> > +#include <linux/delay.h> > > #include "hdmi.h" > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c > index a68eea4153fc..e1bd9b357617 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c > @@ -15,6 +15,8 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/delay.h> > + > #include "hdmi.h" > > static void hdmi_phy_8x60_powerup(struct hdmi_phy *phy, > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c b/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c > index c6dae6e437f9..eff970f8ab8c 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c > @@ -17,6 +17,8 @@ > */ > > #include <linux/clk-provider.h> > +#include <linux/delay.h> > + > #include "hdmi.h" > > struct hdmi_pll_8960 { > diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c > index 131c23a267ee..20387be1b810 100644 > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -16,6 +16,7 @@ > */ > > #include <drm/drm_atomic_uapi.h> > +#include <drm/drm_vblank.h> > > #include "msm_drv.h" > #include "msm_gem.h" > diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c > index 67ef300559cf..b3ae7b7ab5d8 100644 > --- a/drivers/gpu/drm/msm/msm_debugfs.c > +++ b/drivers/gpu/drm/msm/msm_debugfs.c > @@ -16,7 +16,12 @@ > */ > > #ifdef CONFIG_DEBUG_FS > + > #include <linux/debugfs.h> > + > +#include <drm/drm_debugfs.h> > +#include <drm/drm_file.h> > + > #include "msm_drv.h" > #include "msm_gpu.h" > #include "msm_kms.h" > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 229d49740677..af937d5cf032 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -16,9 +16,18 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/dma-mapping.h> > #include <linux/kthread.h> > +#include <linux/uaccess.h> > #include <uapi/linux/sched/types.h> > + > +#include <drm/drm_drv.h> > +#include <drm/drm_file.h> > +#include <drm/drm_ioctl.h> > +#include <drm/drm_irq.h> > +#include <drm/drm_prime.h> > #include <drm/drm_of.h> > +#include <drm/drm_vblank.h> > > #include "msm_drv.h" > #include "msm_debugfs.h" > @@ -28,7 +37,6 @@ > #include "msm_kms.h" > #include "adreno/adreno_gpu.h" > > - > /* > * MSM driver version: > * - 1.0.0 - initial interface > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index d9aa7bad454d..ee2c3a2636d0 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -36,7 +36,6 @@ > #include <linux/sizes.h> > #include <linux/kthread.h> > > -#include <drm/drmP.h> > #include <drm/drm_atomic.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_plane_helper.h> > diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c > index a816ceb58716..7b1b8c5466ec 100644 > --- a/drivers/gpu/drm/msm/msm_fb.c > +++ b/drivers/gpu/drm/msm/msm_fb.c > @@ -17,6 +17,8 @@ > > #include <drm/drm_crtc.h> > #include <drm/drm_damage_helper.h> > +#include <drm/drm_file.h> > +#include <drm/drm_fourcc.h> > #include <drm/drm_gem_framebuffer_helper.h> > #include <drm/drm_probe_helper.h> > > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c > index d088299babf3..d776512f97cd 100644 > --- a/drivers/gpu/drm/msm/msm_fbdev.c > +++ b/drivers/gpu/drm/msm/msm_fbdev.c > @@ -17,6 +17,7 @@ > > #include <drm/drm_crtc.h> > #include <drm/drm_fb_helper.h> > +#include <drm/drm_fourcc.h> > > #include "msm_drv.h" > #include "msm_kms.h" > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index d31d9f927887..ad7230aedaf7 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -20,6 +20,8 @@ > #include <linux/dma-buf.h> > #include <linux/pfn_t.h> > > +#include <drm/drm_prime.h> > + > #include "msm_drv.h" > #include "msm_fence.h" > #include "msm_gem.h" > diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c > index 60bb290700ce..1c957a6e7c23 100644 > --- a/drivers/gpu/drm/msm/msm_gem_prime.c > +++ b/drivers/gpu/drm/msm/msm_gem_prime.c > @@ -15,11 +15,13 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/dma-buf.h> > + > +#include <drm/drm_prime.h> > + > #include "msm_drv.h" > #include "msm_gem.h" > > -#include <linux/dma-buf.h> > - > struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj) > { > struct msm_gem_object *msm_obj = to_msm_bo(obj); > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index d3801bfa4407..f7390ac5f4c8 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -15,7 +15,11 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/file.h> > #include <linux/sync_file.h> > +#include <linux/uaccess.h> > + > +#include <drm/drm_file.h> > > #include "msm_drv.h" > #include "msm_gpu.h" > diff --git a/drivers/gpu/drm/msm/msm_gpummu.c b/drivers/gpu/drm/msm/msm_gpummu.c > index 27312b553dd8..34f643a0c28a 100644 > --- a/drivers/gpu/drm/msm/msm_gpummu.c > +++ b/drivers/gpu/drm/msm/msm_gpummu.c > @@ -1,6 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0 > /* Copyright (c) 2018 The Linux Foundation. All rights reserved. */ > > +#include <linux/dma-mapping.h> > + > #include "msm_drv.h" > #include "msm_mmu.h" > #include "adreno/adreno_gpu.h" > diff --git a/drivers/gpu/drm/msm/msm_perf.c b/drivers/gpu/drm/msm/msm_perf.c > index 95948cfe7a12..f26997daee4c 100644 > --- a/drivers/gpu/drm/msm/msm_perf.c > +++ b/drivers/gpu/drm/msm/msm_perf.c > @@ -26,6 +26,9 @@ > #ifdef CONFIG_DEBUG_FS > > #include <linux/debugfs.h> > +#include <linux/uaccess.h> > + > +#include <drm/drm_file.h> > > #include "msm_drv.h" > #include "msm_gpu.h" > diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c > index 480d810037ce..7badaae80a9d 100644 > --- a/drivers/gpu/drm/msm/msm_rd.c > +++ b/drivers/gpu/drm/msm/msm_rd.c > @@ -42,11 +42,14 @@ > > #ifdef CONFIG_DEBUG_FS > > -#include <linux/kfifo.h> > -#include <linux/debugfs.h> > #include <linux/circ_buf.h> > +#include <linux/debugfs.h> > +#include <linux/kfifo.h> > +#include <linux/uaccess.h> > #include <linux/wait.h> > > +#include <drm/drm_file.h> > + > #include "msm_drv.h" > #include "msm_gpu.h" > #include "msm_gem.h" > diff --git a/drivers/gpu/drm/msm/msm_submitqueue.c b/drivers/gpu/drm/msm/msm_submitqueue.c > index c70e00e22c4c..001fbf537440 100644 > --- a/drivers/gpu/drm/msm/msm_submitqueue.c > +++ b/drivers/gpu/drm/msm/msm_submitqueue.c > @@ -3,6 +3,8 @@ > */ > > #include <linux/kref.h> > +#include <linux/uaccess.h> > + > #include "msm_gpu.h" > > void msm_submitqueue_destroy(struct kref *kref) > -- > 2.20.1 > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
