Hi, On 8/1/19 4:59 PM, Sam Ravnborg wrote:
Hi Hans. On Tue, Jul 30, 2019 at 03:38:56PM +0200, Hans de Goede wrote:3 small cleanups: 1) Drop unused DRIVER_PATCHLEVEL 2) We do not set mode_config.preferred_depth, so instead of passing the unset mode_config.preferred_depth to drm_fbdev_generic_setup simply pass 0 3) Use __maybe_unused instead of #ifdef CONFIG_PM around the suspend / resume functions Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> Suggested-by: Sam Ravnborg <sam@xxxxxxxxxxxx>If you add: Suggested-by: Noralf Trønnes <noralf@xxxxxxxxxxx> And adjust to the new location. Then this is: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Thank you for the review. I will push this to drm-misc-next, with the suggested changes, tomorrow (when I'm back behind my workstation which has all the necessary kernel trees). Regards, Hans _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
