Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Chris Wilson (2019-08-09 12:58:51)
> Quoting Lionel Landwerlin (2019-08-09 12:30:30)
> > +               if (flags & I915_DRM_SYNCOBJ_BINARY_ITEM_VALUE_READ) {
> > +                       copy_to_user(&values[i], &syncobjs[i]->binary_payload, sizeof(values[i]));
> > +                       ret = ret ? -EFAULT : 0;
> 
> More magic.
> 
> if (put_user(&syncobjs[i]->binary_payload, &values[i]))
>         return -EFAULT;

(break not yet)

Should just be put_user(syncobjs[i]->binary_payload, &values[i])
The value of, not its address.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux