On Wed, Aug 07, 2019 at 03:01:59PM +0100, Chris Wilson wrote: > Quoting Christian König (2019-08-07 14:54:05) > > The ruc and cb_list are never used at the same time. > > This smal change is actually making the structure 16% smaller. > (Trivial pair of typos) > > Yes. We clear the callback list on kref_put so that by the time we > release the fence it is unused. No one should be adding to the cb_list > that they don't themselves hold a reference for, this only now makes for > a much more spectacular use-after-free. :) ^^ stuff the above as an inline kerneldoc comment into the patch? And into the commit message too pls. We need better docs for all this scorcery :-) Thanks, Daniel > > > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > -Chris > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
