On Wed, Aug 07, 2019 at 04:59:51PM +0100, Emil Velikov wrote: > On Wed, 7 Aug 2019 at 15:53, Sean Paul <sean@xxxxxxxxxx> wrote: > > > > From: Rob Herring <robh@xxxxxxxxxx> > > > > This reverts commit 583bbf46133c726bae277e8f4e32bfba2a528c7f. > > > > Turns out we need mmap to work on imported BOs even if the current code > > is buggy. > > > Personally I would have mentioned a use case where imported BOs are used. > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Sean Paul <sean@xxxxxxxxxx> > > Regardless of the above nitpick, with the patch order fixed the series is: > Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > ... in case you haven't picked it already. Yeah a follow-up patch to add a comment here about why exactly this went all kaboom, plus which userspace (since panfrost is moving fast) would be real nice here. Atm we need to hope someone does a git blame on this before the break this again, which seems a bit hopeful ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
