Hi Laurent,
Thank you for your feedback!
> From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Sent: 02 August 2019 09:22
> Subject: Re: [PATCH/RFC 08/12] drm: rcar-du: lvds: Fix bridge_to_rcar_lvds
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Fri, Aug 02, 2019 at 08:34:05AM +0100, Fabrizio Castro wrote:
> > Using name "bridge" for macro bridge_to_rcar_lvds argument doesn't
> > work when the pointer name used by the caller is not "bridge".
> > Rename the argument to "bridge_ptr" to allow for any pointer
> > name.
> >
> > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver")
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_lvds.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > index 97c51c2..edd63f5 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > @@ -72,8 +72,8 @@ struct rcar_lvds {
> > bool stripe_swap_data;
> > };
> >
> > -#define bridge_to_rcar_lvds(bridge) \
> > - container_of(bridge, struct rcar_lvds, bridge)
> > +#define bridge_to_rcar_lvds(bridge_ptr) \
> > + container_of(bridge_ptr, struct rcar_lvds, bridge)
>
> How about just 'b' instead of 'bridge_ptr' ? If that's fine with you
> I'll take the modified patch in my tree, no need to resubmit.
That's fine by me, thank your fixing.
Thanks,
Fab
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> >
> > #define connector_to_rcar_lvds(connector) \
> > container_of(connector, struct rcar_lvds, connector)
>
> --
> Regards,
>
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
