On Sun, 2019-08-04 at 22:16 +0200, Sam Ravnborg wrote: > Replace open coded version with call to drm_panel_get_modes(). > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Jonas Karlman <jonas@xxxxxxxxx> > Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxx> > --- > drivers/gpu/drm/bridge/tc358767.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c > index 42f03a985ac0..cebc8e620820 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -1312,7 +1312,7 @@ static int tc_connector_get_modes(struct drm_connector *connector) > { > struct tc_data *tc = connector_to_tc(connector); > struct edid *edid; > - unsigned int count; > + int count; This looks like it also fixes a potential bug ... > int ret; > > ret = tc_get_display_props(tc); > @@ -1321,11 +1321,9 @@ static int tc_connector_get_modes(struct drm_connector *connector) > return 0; > } > > - if (tc->panel && tc->panel->funcs && tc->panel->funcs->get_modes) { > - count = tc->panel->funcs->get_modes(tc->panel); > - if (count > 0) ... when .get_modes returns a negative value. > - return count; > - } > + count = drm_panel_get_modes(tc->panel); > + if (count > 0) > + return count; > > edid = drm_get_edid(connector, &tc->aux.ddc); Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> regards Philipp _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel