|
From: Alex Deucher <alexdeucher@xxxxxxxxx>
Sent: Friday, August 2, 2019 2:53 AM To: Colin King <colin.king@xxxxxxxxxxxxx> Cc: Wang, Kevin(Yang) <Kevin1.Wang@xxxxxxx>; Rex Zhu <rex.zhu@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Zhou, David(ChunMing) <David1.Zhou@xxxxxxx>; David Airlie <airlied@xxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; Maling list - DRI developers <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; kernel-janitors@xxxxxxxxxxxxxxx <kernel-janitors@xxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx> Subject: Re: [PATCH][drm-next] drm/amd/powerplay: fix off-by-one upper bounds limit checks On Thu, Aug 1, 2019 at 7:15 AM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > There are two occurrances of off-by-one upper bound checking of indexes > causing potential out-of-bounds array reads. Fix these. > > Addresses-Coverity: ("Out-of-bounds read") > Fixes: cb33363d0e85 ("drm/amd/powerplay: add smu feature name support") > Fixes: 6b294793e384 ("drm/amd/powerplay: add smu message name support") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index d029a99e600e..b64113740eb5 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -38,7 +38,7 @@ static const char* __smu_message_names[] = { > > const char *smu_get_message_name(struct smu_context *smu, enum smu_message_type type) > { > - if (type < 0 || type > SMU_MSG_MAX_COUNT) > + if (type < 0 || type >= SMU_MSG_MAX_COUNT) > return "unknown smu message"; > return __smu_message_names[type]; > } > @@ -51,7 +51,7 @@ static const char* __smu_feature_names[] = { > > const char *smu_get_feature_name(struct smu_context *smu, enum smu_feature_mask feature) > { > - if (feature < 0 || feature > SMU_FEATURE_COUNT) > + if (feature < 0 || feature >= SMU_FEATURE_COUNT) > return "unknown smu feature"; > return __smu_feature_names[feature]; > } [kevin]:
thanks correct it.
Reviewed-by: Kevin Wang <kevin1.wang@xxxxxxx>
BR
Kevin
> --
> 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel |
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
