Hi Andrzej, I had to revert the previous patch, so you should re-spin it entirely : ================================ After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_connector': drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: error: 'ddc' undeclared (first use in this function) ddc = &radeon_connector->ddc_bus->adapter; ^~~ drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: note: each undeclared identifier is reported only once for each function it appears in Caused by commit bed7a2182de6 ("drm/radeon: Provide ddc symlink in connector sysfs directory") I have used the drm-misc tree from next-20190731 for today. ================================== Neil On 31/07/2019 18:58, Andrzej Pietrasiewicz wrote: > ddc local variable is passed to drm_connector_init_with_ddc() and should > be NULL if no ddc is available. > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx> > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c > index b3ad8d890801..d11131d03ed6 100644 > --- a/drivers/gpu/drm/radeon/radeon_connectors.c > +++ b/drivers/gpu/drm/radeon/radeon_connectors.c > @@ -1870,7 +1870,7 @@ radeon_add_atom_connector(struct drm_device *dev, > struct radeon_connector_atom_dig *radeon_dig_connector; > struct drm_encoder *encoder; > struct radeon_encoder *radeon_encoder; > - struct i2c_adapter *ddc; > + struct i2c_adapter *ddc = NULL; > uint32_t subpixel_order = SubPixelNone; > bool shared_ddc = false; > bool is_dp_bridge = false; > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel