Re: [RFC 4/4] drm/panel/ili9341: Support mi0283qt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019/07/30, Daniel Vetter wrote:
> On Tue, Jul 30, 2019 at 4:30 PM Noralf Trønnes <noralf@xxxxxxxxxxx> wrote:
> >
> >
> >
> > Den 29.07.2019 21.55, skrev Noralf Trønnes:
> > > Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
> > > ---
> > >  drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 179 ++++++++++++++++++-
> > >  1 file changed, 170 insertions(+), 9 deletions(-)
> > >
> >
> > I have realised that this will change the DRM driver name from mi0283qt
> > to drm_mipi_dbi. This means that this panel will loose its MESA kmsro[1]
> > support. I haven't tried it, but this is the first thing that gives this
> > driver any real advantage over its fbdev counterpart in
> > drivers/staging/fbtft, so I don't want to loose that.
> > So even if MIPI DBI panel support is implemented in some form, I will
> > wait with converting mi0283qt until someone has updated the kmsro driver.
> 
> Why does it change? You should be able to stuff whatever you feel like
> into the drm driver name, this doesn't have to match either your
> platform/spi/whatever driver name nor the module option.

Last time i've looked DRM drivers using the mipi dsi helpers do _not_
have "drm_mipi_dsi" as their driver name. Hence drivers using the mipi
dbi should not have "drm_mipi_dbi".

That said, we should probably highlight even more that the driver name
is an ABI.

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux