Re: [PATCH] drm/i810: Use CONFIG_PREEMPTION

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 26, 2019 at 10:25 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by
> CONFIG_PREEMPT_RT. Both PREEMPT and PREEMPT_RT require the same
> functionality which today depends on CONFIG_PREEMPT.
>
> Change the Kconfig dependency of i810 to !CONFIG_PREEMPTION so the driver
> is not accidentally built on a RT kernel.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>

My kernel/Kconfig.preempt here still has that as PREEMPT. Does this
patch need some others? In that case Ack for merging through whatever
tree those go in through.
-Daniel

> ---
>  drivers/gpu/drm/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -394,7 +394,7 @@ config DRM_R128
>  config DRM_I810
>         tristate "Intel I810"
>         # !PREEMPT because of missing ioctl locking
> -       depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN)
> +       depends on DRM && AGP && AGP_INTEL && (!PREEMPTION || BROKEN)
>         help
>           Choose this option if you have an Intel I810 graphics card.  If M is
>           selected, the module will be called i810.  AGP support is required



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux