On Tue, Jun 11, 2019 at 12:08:21PM -0400, Sean Paul wrote: > From: Sean Paul <seanpaul@xxxxxxxxxxxx> > > Once we start shutting off the link during PSR, we're going to want fast > training to work. If the display doesn't support fast training, don't > enable psr. > > Changes in v2: > - None > Changes in v3: > - None > Changes in v4: > - None > Changes in v5: > - None > > Link to v1: https://patchwork.freedesktop.org/patch/msgid/20190228210939.83386-3-sean@xxxxxxxxxx > Link to v2: https://patchwork.freedesktop.org/patch/msgid/20190326204509.96515-2-sean@xxxxxxxxxx > Link to v3: https://patchwork.freedesktop.org/patch/msgid/20190502194956.218441-9-sean@xxxxxxxxxx > Link to v4: https://patchwork.freedesktop.org/patch/msgid/20190508160920.144739-8-sean@xxxxxxxxxx > > Cc: Zain Wang <wzz@xxxxxxxxxxxxxx> > Cc: Tomasz Figa <tfiga@xxxxxxxxxxxx> > Tested-by: Heiko Stuebner <heiko@xxxxxxxxx> @Heiko, could you please review patches 7-11? I'm worried they're going to start to rot and the helpers have already landed in Linus' tree. Thanks, Sean > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index d2de98d441845..a07d19e08b803 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1040,16 +1040,17 @@ static int analogix_dp_commit(struct analogix_dp_device *dp) > if (ret) > return ret; > > + /* Check whether panel supports fast training */ > + ret = analogix_dp_fast_link_train_detection(dp); > + if (ret) > + dp->psr_enable = false; > + > if (dp->psr_enable) { > ret = analogix_dp_enable_sink_psr(dp); > if (ret) > return ret; > } > > - /* Check whether panel supports fast training */ > - ret = analogix_dp_fast_link_train_detection(dp); > - if (ret) > - dp->psr_enable = false; > > return ret; > } > -- > Sean Paul, Software Engineer, Google / Chromium OS > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
