On Tue, 2019-07-09 at 03:11 +0000, Wen He wrote: [...] > > Thank you for the patch, but this does not seem right. > > ipuv3-crtc.c is part of DRM_IMX, which already depends on IMX_IPUV3_CORE. > > How did you manage to make it try to compile imxdrm? I assume the answer to my question is that you have removed the IMX_IPUV3_CORE dependency in the LS1028A BSP? > Thanks for the review, Philipp, > > NXP LS1028A platform use same Display IP with IMX8, so they have use same display > transmit controller drivers, config 'DRM_IMX' is used to support drm common drivers > on the NXP I.MX and LS1028A, display transmit controller is coming to plan upstream. Is it the i.MX8MQ DCSS or the i.MX8QM DPU that is shared with LS1028A? > Actually, we have done compile of the imxdrm on LS1028A BSP release. Can you point me changes that have been applied? It is still unclear to me how you managed to build imx-drm, unless you have removed the IMX_IPUV3_CORE dependency from DRM_IMX. > > Since LS1028A does not have the IPUv3, keeping this under COMPILE_TEST > > should be correct. > > Although LS1028A does not have the IPVv3, but DRM_IMX depends on it, LS1028A display > Transmit controller drivers also depends on DRM_IMX, so we need add this dependency to > solve the compile issue. The imx-drm driver is not suited to drive the i.MX8 display controllers. They should get their own drm drivers, as they have nothing in common with the i.MX5/6 IPU. There are no video capture capabilities, so they don't need the subsystem spanning driver layout, and without muxable shared encoders there is no need for the component design either. regards Philipp _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
