Re: [PATCH] drm: use correct dev node location in comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 22, 2019 at 05:56:48PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
> 
> Current comment mentions /dev/drm which hasn't been a thing even before
> the code was merged into the kernel ;-)
> 
> Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index ea34bc991858..5274b40eb5e3 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -285,7 +285,7 @@ static int drm_cpu_valid(void)
>  }
>  
>  /*
> - * Called whenever a process opens /dev/drm.
> + * Called whenever a process opens /dev/dri/[number]

Well, /dev/dri/[number] also doesn't exist. You could change to:

+ * Called whenever a process opens /dev/dri/(card|render)[number]

or don't try to specify the exact path and say:

+ * Called whenever a process opens a drm node


Either way, 

Reviewed-by: Sean Paul <sean@xxxxxxxxxx>


>   *
>   * \param filp file pointer.
>   * \param minor acquired minor-object.
> -- 
> 2.21.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux