Re: [PATCH 1/4] drm/amdgpu: Add flag to wipe VRAM on release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 20.07.19 um 00:02 schrieb Kuehling, Felix:
This memory allocation flag will be used to indicate BOs containing
sensitive data that should not be leaked to other processes.

Just a nit pick, but I would reorder the series and make patch #3 the first and #2 the last one.

Just to have a clean order between adding the callback to the TTM code, implementing the new flag and using it as last step.

Apart from that the series is Reviewed-by: Christian König <christian.koenig@xxxxxxx>.

Regards,
Christian.


Signed-off-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>
---
  include/uapi/drm/amdgpu_drm.h | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index d49571dab2a1..ca97b6802275 100644
--- a/include/uapi/drm/amdgpu_drm.h
+++ b/include/uapi/drm/amdgpu_drm.h
@@ -131,6 +131,10 @@ extern "C" {
   * for the second page onward should be set to NC.
   */
  #define AMDGPU_GEM_CREATE_MQD_GFX9		(1 << 8)
+/* Flag that BO may contain sensitive data that must be wiped before
+ * releasing the memory
+ */
+#define AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE	(1 << 9)
struct drm_amdgpu_gem_create_in {
  	/** the requested memory size */

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux