Hi Noralf. On Sun, Jul 21, 2019 at 06:48:46PM +0200, Noralf Trønnes wrote: > > > Den 21.07.2019 16.06, skrev Sam Ravnborg: > > After migrating several drivers to the generic fbdev there are > > no users left. Delete the function. > > > > Noticed that there was no callers while browsing > > around in the drm_fb* code. > > > > Last user was removed with: > > commit 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code") > > commit 26d4707d445d ("drm/qxl: use generic fbdev emulation") > > Listing 2 commits for the same driver was confusing. I think you can > drop the second one since it's the first that contained the function call. I updated the changelog like this and applied and pushed out. Thanks, Sam Changelog: After migrating several drivers to the generic fbdev emulation there are no users left of drm_gem_fbdev_fb_create. Delete the function. Noticed that there was no callers while browsing around in the drm_fb* code. The code that referenced the function was removed by: commit 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code") The actual use was removed by: commit 26d4707d445d ("drm/qxl: use generic fbdev emulation") v2: - Updated changelog based on feedback from Noralf Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Reviewed-by: Noralf Trønnes <noralf@xxxxxxxxxxx> Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> Link: https://patchwork.freedesktop.org/patch/msgid/20190721140610.GA20842@xxxxxxxxxxxx _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel