Hi Noralf. Good to see a long journey end with a very nice result. I only entered the DRM world for the last parts of the journey, but nevertheless impressed by all the nice refactoring done. On Sat, Jul 20, 2019 at 03:47:03PM +0200, Noralf Trønnes wrote: > This series ticks off the last tinydrm todo entry and moves out mipi_dbi > to be a core helper. > > It splits struct mipi_dbi into an interface part and a display pipeline > part (upload framebuffer over SPI). I also took the opportunity to > rename the ambiguous 'mipi' variable name to 'dbi'. This lines up with > the use of the 'dsi' variable name in the MIPI DSI helper. > > Note: > This depends on series: drm/tinydrm: Remove tinydrm.ko > > Series is also available here: > https://github.com/notro/linux/tree/move_mipi_dbi > > Noralf. > > Noralf Trønnes (6): > drm/tinydrm/mipi-dbi: Move cmdlock mutex init > drm/tinydrm: Rename variable mipi -> dbi > drm/tinydrm: Rename remaining variable mipi -> dbidev > drm/tinydrm: Split struct mipi_dbi in two > drm/tinydrm: Move mipi-dbi > MAINTAINERS: Remove tinydrm entry I have read all patches - looks good. In "Split struct mipi_dbi in two" the documentation for the struct members is moved inside the struct - this makes it more readbale and is good. This could have been an independent patch, or at least mentioned in the changelog. You can for all patches add: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
