On Tue, Jul 16, 2019 at 7:57 PM Cheng-Yi Chiang <cychiang@xxxxxxxxxxxx> wrote: > > Change the Kconfig of DRM_DW_HDMI so it selects SND_SOC_HDMI_CODEC. > This is for the typedef of hdmi_codec_plugged_cb to be used in dw-hdmi.c. Not sure why you select SND_SOC_HDMI_CODEC in this patch. To have definition of hdmi_codec_plugged_cb, include hdmi-codec.h should be sufficient. > > diff --git a/drivers/gpu/drm/bridge/synopsys/Kconfig b/drivers/gpu/drm/bridge/synopsys/Kconfig > index 21a1be3ced0f..309da052db97 100644 > --- a/drivers/gpu/drm/bridge/synopsys/Kconfig > +++ b/drivers/gpu/drm/bridge/synopsys/Kconfig > @@ -4,6 +4,7 @@ config DRM_DW_HDMI > select DRM_KMS_HELPER > select REGMAP_MMIO > select CEC_CORE if CEC_NOTIFIER > + select SND_SOC_HDMI_CODEC So that it is weird to select this option. > > config DRM_DW_HDMI_AHB_AUDIO > tristate "Synopsys Designware AHB Audio interface" > @@ -20,7 +21,6 @@ config DRM_DW_HDMI_I2S_AUDIO > tristate "Synopsys Designware I2S Audio interface" > depends on SND_SOC > depends on DRM_DW_HDMI > - select SND_SOC_HDMI_CODEC Also strange for deselecting the option. Should be in another commit for another reason? _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
