Re: [PATCH v2 03/19] drm/pl111: drop use of drmP.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 16, 2019 at 2:44 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> Drop use of the deprecated drmP.h header.
> Sort includes in blocks while touching the files.
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Acked-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
> Cc: Eric Anholt <eric@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/pl111/pl111_debugfs.c   |  4 +++-
>  drivers/gpu/drm/pl111/pl111_display.c   |  6 ++++--
>  drivers/gpu/drm/pl111/pl111_drm.h       | 11 ++++++-----
>  drivers/gpu/drm/pl111/pl111_drv.c       |  9 +++++----
>  drivers/gpu/drm/pl111/pl111_nomadik.h   |  3 ++-
>  drivers/gpu/drm/pl111/pl111_versatile.c |  9 +++++----
>  drivers/gpu/drm/pl111/pl111_versatile.h |  3 +++
>  7 files changed, 28 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_debugfs.c b/drivers/gpu/drm/pl111/pl111_debugfs.c
> index 7ddc7e3b9e7d..7accfd6f7bde 100644
> --- a/drivers/gpu/drm/pl111/pl111_debugfs.c
> +++ b/drivers/gpu/drm/pl111/pl111_debugfs.c
> @@ -8,8 +8,10 @@
>
>  #include <linux/amba/clcd-regs.h>
>  #include <linux/seq_file.h>
> +
>  #include <drm/drm_debugfs.h>
> -#include <drm/drmP.h>
> +#include <drm/drm_file.h>
> +
>  #include "pl111_drm.h"
>
>  #define REGDEF(reg) { reg, #reg }
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index 15d2755fdba4..a246195dc606 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -11,14 +11,16 @@
>
>  #include <linux/amba/clcd-regs.h>
>  #include <linux/clk.h>
> +#include <linux/delay.h>
>  #include <linux/version.h>
>  #include <linux/dma-buf.h>
>  #include <linux/of_graph.h>
>
> -#include <drm/drmP.h>
> +#include <drm/drm_fb_cma_helper.h>
> +#include <drm/drm_fourcc.h>
>  #include <drm/drm_gem_cma_helper.h>
>  #include <drm/drm_gem_framebuffer_helper.h>
> -#include <drm/drm_fb_cma_helper.h>
> +#include <drm/drm_vblank.h>
>
>  #include "pl111_drm.h"
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drm.h b/drivers/gpu/drm/pl111/pl111_drm.h
> index b2c5e9f34051..77d2da9a8a7c 100644
> --- a/drivers/gpu/drm/pl111/pl111_drm.h
> +++ b/drivers/gpu/drm/pl111/pl111_drm.h
> @@ -13,14 +13,15 @@
>  #ifndef _PL111_DRM_H_
>  #define _PL111_DRM_H_
>
> -#include <drm/drm_gem.h>
> -#include <drm/drm_simple_kms_helper.h>
> +#include <linux/clk-provider.h>
> +#include <linux/interrupt.h>
> +
> +#include <drm/drm_bridge.h>
>  #include <drm/drm_connector.h>
>  #include <drm/drm_encoder.h>
> +#include <drm/drm_gem.h>
>  #include <drm/drm_panel.h>
> -#include <drm/drm_bridge.h>
> -#include <linux/clk-provider.h>
> -#include <linux/interrupt.h>
> +#include <drm/drm_simple_kms_helper.h>
>
>  #define CLCD_IRQ_NEXTBASE_UPDATE BIT(2)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index 90fa99a7dfa9..276b53473a84 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -48,18 +48,18 @@
>
>  #include <linux/amba/bus.h>
>  #include <linux/amba/clcd-regs.h>
> -#include <linux/version.h>
> -#include <linux/shmem_fs.h>
>  #include <linux/dma-buf.h>
>  #include <linux/module.h>
> -#include <linux/slab.h>
>  #include <linux/of.h>
>  #include <linux/of_graph.h>
>  #include <linux/of_reserved_mem.h>
> +#include <linux/shmem_fs.h>
> +#include <linux/slab.h>
> +#include <linux/version.h>
>
> -#include <drm/drmP.h>
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_bridge.h>
> +#include <drm/drm_drv.h>
>  #include <drm/drm_fb_cma_helper.h>
>  #include <drm/drm_fb_helper.h>
>  #include <drm/drm_gem_cma_helper.h>
> @@ -67,6 +67,7 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  #include <drm/drm_probe_helper.h>
> +#include <drm/drm_vblank.h>
>
>  #include "pl111_drm.h"
>  #include "pl111_versatile.h"
> diff --git a/drivers/gpu/drm/pl111/pl111_nomadik.h b/drivers/gpu/drm/pl111/pl111_nomadik.h
> index 19d663d46353..47ccf5c839fc 100644
> --- a/drivers/gpu/drm/pl111/pl111_nomadik.h
> +++ b/drivers/gpu/drm/pl111/pl111_nomadik.h
> @@ -1,10 +1,11 @@
>  // SPDX-License-Identifier: GPL-2.0+
> -#include <linux/device.h>
>
>  #ifndef PL111_NOMADIK_H
>  #define PL111_NOMADIK_H
>  #endif
>
> +struct device;
> +
>  #ifdef CONFIG_ARCH_NOMADIK
>
>  void pl111_nomadik_init(struct device *dev);
> diff --git a/drivers/gpu/drm/pl111/pl111_versatile.c b/drivers/gpu/drm/pl111/pl111_versatile.c
> index 38f4ee05285e..09aeaffb7660 100644
> --- a/drivers/gpu/drm/pl111/pl111_versatile.c
> +++ b/drivers/gpu/drm/pl111/pl111_versatile.c
> @@ -1,13 +1,14 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> +
>  #include <linux/amba/clcd-regs.h>
> +#include <linux/bitops.h>
>  #include <linux/device.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/regmap.h>
> -#include <linux/mfd/syscon.h>
> -#include <linux/bitops.h>
> -#include <linux/module.h>
> -#include <drm/drmP.h>
> +
>  #include "pl111_versatile.h"
>  #include "pl111_vexpress.h"
>  #include "pl111_drm.h"
> diff --git a/drivers/gpu/drm/pl111/pl111_versatile.h b/drivers/gpu/drm/pl111/pl111_versatile.h
> index 41aa6d969dc6..143877010042 100644
> --- a/drivers/gpu/drm/pl111/pl111_versatile.h
> +++ b/drivers/gpu/drm/pl111/pl111_versatile.h
> @@ -4,6 +4,9 @@
>  #ifndef PL111_VERSATILE_H
>  #define PL111_VERSATILE_H
>
> +struct device;
> +struct pl111_drm_dev_private;
> +
>  int pl111_versatile_init(struct device *dev, struct pl111_drm_dev_private *priv);
>
>  #endif
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux