Re: [PATCH v3] gpu/drm_memory: fix a few warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Qian,

On 2019/07/12, Qian Cai wrote:
> Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit
> about SPDX can pick this up. It occurs to me none of DRM maintainers cares about
> this as there is no feedback from any of them for months since v1.
> 
AFAICT there are a couple of reasons why this has gone unnoticed:
 - summary is the pretty ambiguous
 - commit does two thigs

Another thing to consider is that this patch touches a single file,
while the exact same issue is also present in many other files.

Quick look at the following lists:
head -n2 drivers/gpu/drm/drm_*[ch]  | less

drm_agpsupport.c
drm_dma.c
drm_legacy_misc.c
drm_lock.c
drm_memory.c
drm_scatter.c
drm_vm.c

If you can fixup the s|/**|/*| in the above, I'd gladly merge the patch.

On the topic of SPDX - no objection on my end, but it should be a
separate patch, which replaces the explicit verbose license text with
the tag.

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux