On Mon, Jul 08, 2019 at 10:18:16AM +0200, Sam Ravnborg wrote: > Hi Maya. > > Nice catch - good to remove unused cruft. > > Please prefix the subject with something like "drm/agp: ". > Check "git log" on the same file to pick up the usual way to identify > agp specific changes. > > With this fixed: > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > You could also consider to add a few words in the body of the changelog > how the unused function was identified. Also needs sob per https://dri.freedesktop.org/docs/drm/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin -Daniel > > Sam > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel