Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Brian

On 7/9/19 12:48 PM, Brian Dodge wrote:
FYI: please note that pSemi's legal department has informed me that they do *not* want to keep the "ArcticSand" copyright notices and the single pSemi line is appropriate. 

Thanks for the follow up.  Lawyers can be fickle about this stuff.


On Mon, Jul 8, 2019 at 2:02 PM Dan Murphy <dmurphy@xxxxxx> wrote:
Brian

On 6/30/19 7:28 PM, Brian Dodge wrote:
> The vendor-prefixes.txt file properly refers to ArcticSand
> as arctic but the driver bindings improperly abbreviated the
> prefix to arc. This was a mistake in the original patch. This
> patch adds "arctic" and retains "arc" (deprecated) bindings
>
> Signed-off-by: Brian Dodge <bdodge09@xxxxxxxxx>
> ---
>   .../bindings/leds/backlight/arcxcnn_bl.txt         | 31 +++++++++++++++-------
>   1 file changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> index 230abde..4d98394 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> @@ -1,8 +1,13 @@
> -Binding for ArcticSand arc2c0608 LED driver
> +Binding for ArcticSand arc family LED drivers
>   
>   Required properties:
> -- compatible:                should be "arc,arc2c0608"
> -- reg:                       slave address
> +- compatible: one of
> +     "arctic,arc1c0608"
> +     "arctic,arc2c0608"
> +     "arctic,arc3c0845"
> +     "arc,arc2c0608" (deprecated)
> +
> +- reg:               slave address
>   
>   Optional properties:
>   - default-brightness:       brightness value on boot, value from: 0-4095
> @@ -11,19 +16,25 @@ Optional properties:
>   - led-sources:              List of enabled channels from 0 to 5.
>                       See Documentation/devicetree/bindings/leds/common.txt
>   
> -- arc,led-config-0:  setting for register ILED_CONFIG_0
> -- arc,led-config-1:  setting for register ILED_CONFIG_1
> -- arc,dim-freq:              PWM mode frequence setting (bits [3:0] used)
> -- arc,comp-config:   setting for register CONFIG_COMP
> -- arc,filter-config: setting for register FILTER_CONFIG
> -- arc,trim-config:   setting for register IMAXTUNE
> +- arctic,led-config-0:       setting for register ILED_CONFIG_0
> +- arctic,led-config-1:       setting for register ILED_CONFIG_1
> +- arctic,dim-freq:   PWM mode frequence setting (bits [3:0] used)
> +- arctic,comp-config:        setting for register CONFIG_COMP
> +- arctic,filter-config:      setting for register FILTER_CONFIG
> +- arctic,trim-config:        setting for register IMAXTUNE
> +- arc,led-config-0:  setting for register ILED_CONFIG_0 (deprecated)
> +- arc,led-config-1:  setting for register ILED_CONFIG_1 (deprecated)
> +- arc,dim-freq:              PWM mode frequence setting (bits [3:0] used) (deprecated)
> +- arc,comp-config:   setting for register CONFIG_COMP (deprecated)
> +- arc,filter-config: setting for register FILTER_CONFIG (deprecated)
> +- arc,trim-config:   setting for register IMAXTUNE (deprecated)
>   
>   Note: Optional properties not specified will default to values in IC EPROM
>   
>   Example:
>   
>   arc2c0608@30 {
> -     compatible = "arc,arc2c0608";
> +     compatible = "arctic,arc2c0608";
>       reg = <0x30>;
>       default-brightness = <500>;
>       label = "lcd-backlight";


Reviewed-by: Dan Murphy <dmurphy@xxxxxx>

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux