On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: > On Mon, Jul 8, 2019 at 2:06 PM Qian Cai <cai@xxxxxx> wrote: > > > > The opening comment mark "/**" is reserved for kernel-doc comments, so > > it will generate a warning with "make W=1". > > > > drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand * \file > > drm_memory.c > > > > Also, silence a checkpatch warning by adding a license identfiter where > > it indicates the MIT license further down in the source file. > > > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > > > It becomes redundant to add both an SPDX identifier and have a > > description of the license in the comment block at the top, so remove > > the later. > > > > Signed-off-by: Qian Cai <cai@xxxxxx> > > --- > > > > v2: remove the redundant description of the license. > > > > drivers/gpu/drm/drm_memory.c | 22 ++-------------------- > > 1 file changed, 2 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c > > index 132fef8ff1b6..86a11fc8e954 100644 > > --- a/drivers/gpu/drm/drm_memory.c > > +++ b/drivers/gpu/drm/drm_memory.c > > @@ -1,4 +1,5 @@ > > -/** > > +// SPDX-License-Identifier: MIT > > +/* > > * \file drm_memory.c > > * Memory management wrappers for DRM > > * > > @@ -12,25 +13,6 @@ > > * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas. > > * Copyright 2000 VA Linux Systems, Inc., Sunnyvale, California. > > * All Rights Reserved. > > - * > > - * Permission is hereby granted, free of charge, to any person obtaining a > > - * copy of this software and associated documentation files (the > > "Software"), > > - * to deal in the Software without restriction, including without > > limitation > > - * the rights to use, copy, modify, merge, publish, distribute, sublicense, > > - * and/or sell copies of the Software, and to permit persons to whom the > > - * Software is furnished to do so, subject to the following conditions: > > - * > > - * The above copyright notice and this permission notice (including the > > next > > - * paragraph) shall be included in all copies or substantial portions of > > the > > - * Software. > > - * > > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS > > OR > > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > > - * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES > > OR > > This talks about VA Linux Systems and/or its suppliers, while the MIT > licence talks about authors or copyright holders. > > Are such transformations OK to just do? From, https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Document ation/process/license-rules.rst "The Linux kernel requires the precise SPDX identifier in all source files." That is the closest license I can think of. Anyway, I have added a few people who may know better of the licensing. > > -ilia > > > - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > > - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > > - * OTHER DEALINGS IN THE SOFTWARE. > > */ > > > > #include <linux/highmem.h> > > -- > > 1.8.3.1 > > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
