Hi Laurent. > > > > + unsigned int i; > > > > index to arrays are default "int" IIRC. > > Not that it matters but noticed it. > > Are they ? I've always advocated for unsigned indexes to use unsigned > int. I did not dig up anything authorative - but found this: https://stackoverflow.com/questions/8111357/type-of-array-index-in-c There is some confusion betwwen the type of array and the type of the index. But the part that looks to answer the questions say that index can be negative, so the integral type is default int. Again, nothing to worry about, as code wokrs and unsigen int is used for index in many places. > > > +MODULE_LICENSE("GPL"); > > > > This should be "GPL v2" if I read https://www.kernel.org/doc/html/latest/process/license-rules.html > > correct. See "MODULE_LICENSE" table. > > According to that table, "GPL v2" is defined as "Same as “GPL”. It > exists for historic reasons.". My understanding is that "GPL v2" exists > for historical reasons and should not be used in new code. Re-reading the link you are right. module license is to be specified as "GPL" and then one has to visit the file. So ignore that comment in following reviews. Seems simple to remember, will keep in mind for future reviews. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
