Re: [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel.

> > drm_file.h:
> > - needs drm_magic_t
> >   drm_magic_t is a simple typedef, a simple unsigned int would do the trick
> 
> I think we could switch over to unsigned int for this.

OK, will send a v2 with this addressed.
There is some preparatory patches to fix build breakage when the include
file is dropped.
> 
> > drm_legacy.h
> > - needs drm_map_type and drm_map_flags. Seems legit.
> 
> enum in uapi, sweet (never do this, it's not portable across compilers,
> #defines all the way). But yeah seems legit, plus we don't care about
> drm_legacy.h
And this part I will happily ignore.
Maybe one day I will check what other dependencies there are.
On a rainy day or when there are no more users of drmP.h or so.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux