On Sat, Jun 22, 2019 at 02:11:54PM +0200, Sam Ravnborg wrote: > include/drm/* shall have no or at least minimal dependencies > to include/uapi/drm/*. > Following two patches do a small effort to drop such dependencies. > > After these patches there are two users > of uapi/drm/drm.h left in include/drm: > > drm_file.h: > - needs drm_magic_t > drm_magic_t is a simple typedef, a simple unsigned int would do the trick I think we could switch over to unsigned int for this. > drm_legacy.h > - needs drm_map_type and drm_map_flags. Seems legit. enum in uapi, sweet (never do this, it's not portable across compilers, #defines all the way). But yeah seems legit, plus we don't care about drm_legacy.h > > I did not spend time to analyze further dependencies. > > Patches are build tested. > > Sam > > Sam Ravnborg (2): > drm: drop uapi dependency from drm_print.h > drm: drop uapi dependency from drm_vblank.h On both Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > include/drm/drm_print.h | 4 +--- > include/drm/drm_vblank.h | 1 - > 2 files changed, 1 insertion(+), 4 deletions(-) > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
