On Thu, Mar 29, 2012 at 12:22:20PM -0500, Ilija Hadzic wrote:
>
>
> On Thu, 29 Mar 2012, Ville [iso-8859-1] Syrjälä wrote:
>
> >> +/* render node create and remove functions
> >> + if crtc/encoders/connectors all == 0 then gpgpu node */
> >> +struct drm_render_node_create {
> >> + __u32 node_minor_id;
> >> + __u32 num_crtc;
> >> + __u32 num_encoder;
> >> + __u32 num_connector;
> >
> > num_plane is missing
> >
>
> Probably because at the time the original patch was created, there was no
> support for planes. I agree, we need to throw planes into this, but I'd
> prefer to do this as a follow-on patch series, rather than amending old
> patches. If for no better reason, than to keep simple relationship between
> the code and it's author (this particular patch is original Dave's patch
> from the days when we had no planes, only rebased to current HEAD).
I think that just makes it harder to review.
It's also part of the ABI, so exposing half finished version of the
struct in the headers, only to later change it, seems like a bad idea.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
