Hi Sam, On Tue, Jan 29, 2019 at 04:48:33PM +0100, Sam Ravnborg wrote: > > > > + } > > > > + > > > > + drm_mode_set_name(mode); > > > > + > > > > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > > > > + drm_mode_probed_add(connector, mode); > > > > + > > > > + panel->connector->display_info.bpc = 8; > > > > + panel->connector->display_info.width_mm = 154; > > > > + panel->connector->display_info.height_mm = 85; > > > See comment on height above. > > > Same goes for bpc > > > > Sorry, I'm not sure to follow you here. bpc and height are both set? > > I assumed that if we had specified height and width in display_mode > then we did not have to do it here. But I may be wrong. It looks like it's not done by the core, but panel-simple simply copies it, so I'll do it as well. Thanks for the suggestion! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
