On Wed, Jan 30, 2019 at 05:13:13PM +0000, Kazlauskas, Nicholas wrote: > On 1/30/19 11:30 AM, Daniel Vetter wrote: > > .. next to all the other sink helpers. The rect library is more used > > for handling plane clipping, so belongs to those imo. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx> > > Looks better than being sandwiched between the HDMI helpers. Flip work > is also plane related in a sense. Yup, that's what I meant with plane helpers - the kms helper intro groups all these (flip, plane helpers, rect stuff, ...) into a plane related helpers pile. Thanks for taking a look, patch merged. -Daniel > > Nicholas Kazlauskas > > > --- > > Documentation/gpu/drm-kms-helpers.rst | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst > > index fbd11b2fe5b5..17ca7f8bf3d3 100644 > > --- a/Documentation/gpu/drm-kms-helpers.rst > > +++ b/Documentation/gpu/drm-kms-helpers.rst > > @@ -296,18 +296,6 @@ SCDC Helper Functions Reference > > .. kernel-doc:: drivers/gpu/drm/drm_scdc_helper.c > > :export: > > > > -Rectangle Utilities Reference > > -============================= > > - > > -.. kernel-doc:: include/drm/drm_rect.h > > - :doc: rect utils > > - > > -.. kernel-doc:: include/drm/drm_rect.h > > - :internal: > > - > > -.. kernel-doc:: drivers/gpu/drm/drm_rect.c > > - :export: > > - > > HDMI Infoframes Helper Reference > > ================================ > > > > @@ -322,6 +310,18 @@ libraries and hence is also included here. > > .. kernel-doc:: drivers/video/hdmi.c > > :export: > > > > +Rectangle Utilities Reference > > +============================= > > + > > +.. kernel-doc:: include/drm/drm_rect.h > > + :doc: rect utils > > + > > +.. kernel-doc:: include/drm/drm_rect.h > > + :internal: > > + > > +.. kernel-doc:: drivers/gpu/drm/drm_rect.c > > + :export: > > + > > Flip-work Helper Reference > > ========================== > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel