Hi Konstantin > >> + ctx->gpios.updn = devm_gpiod_get(&dsi->dev, "updn", GPIOD_OUT_LOW); > >> + if (IS_ERR(ctx->gpios.updn)) { > >> + dev_err(&dsi->dev, "Couldn't get our updn GPIO\n"); > >> + return PTR_ERR(ctx->gpios.updn); > >> + } > > This gpio is never used, it is only read from DT > The gpio is initialized with low state. The state may be inverted by DT. The same for the "shlr". > It is a vertical / horizontal inversion. Ohh, then it makes sense again. Consider adding a comment so this becomes more obvious Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel