On 11/02/2018 02:12 PM, Alex Deucher wrote: > On Fri, Nov 2, 2018 at 11:59 AM Grodzovsky, Andrey > <Andrey.Grodzovsky@xxxxxxx> wrote: >> >> >> On 11/02/2018 10:24 AM, Michel Dänzer wrote: >>> On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote: >>>> Illegal access will cause CP hang followed by job timeout and >>>> recovery kicking in. >>>> Also, disable the suite for all APU ASICs until GPU >>>> reset issues for them will be resolved and GPU reset recovery >>>> will be enabled by default. >>>> >>>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx> >>>> >>>> [...] >>>> >>>> @@ -94,7 +119,9 @@ CU_BOOL suite_deadlock_tests_enable(void) >>>> &minor_version, &device_handle)) >>>> return CU_FALSE; >>>> >>>> - if (device_handle->info.family_id == AMDGPU_FAMILY_SI) { >>>> + if (device_handle->info.family_id == AMDGPU_FAMILY_SI || >>>> + device_handle->info.family_id == AMDGPU_FAMILY_CZ || >>>> + device_handle->info.family_id == AMDGPU_FAMILY_RV) { >>>> printf("\n\nCurrently hangs the CP on this ASIC, deadlock suite disabled\n"); >>>> enable = CU_FALSE; >>>> } >>> Indentation is wrong here and in other places. The libdrm tree contains >>> configuration files for EditorConfig (https://editorconfig.org/); since >>> you're using Eclipse, https://github.com/ncjones/editorconfig-eclipse >>> should help. >> I installed the eclipse plugin. >>> >>> I run amdgpu_test as part of my daily build/test script during lunch >>> break; when I came back today, I was greeted by a GFX hang of the >>> Bonaire in my development box due to this test. Please disable it for >>> all pre-GFX8 ASICs. Ideally, it should also check at runtime that GPU >>> recovery is actually enabled, as that still isn't the case by default >>> except with bleeding edge amdgpu kernel code. >> Thanks for testing - I will send a fix. >> > Have you tried enabling reset on gfx7 dGPUs? It uses pretty much the > same sequence as gfx8 so it might just work. > > Alex I haven't but I can give it a try. Andrey > >> Andrey >>> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel