On Thu, Sep 20, 2018 at 06:30:54PM +0100, Emil Velikov wrote: > On 20 September 2018 at 16:58, Eric Engestrom <eric.engestrom@xxxxxxxxx> wrote: > > Fixes: 36bb0ea47b71d220b31e "intel: annotate public functions" > > Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > > Cc: Mark Janes <mark.a.janes@xxxxxxxxx> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006 > > Signed-off-by: Eric Engestrom <eric.engestrom@xxxxxxxxx> > > --- > > intel/intel_bufmgr_fake.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > This indicated my earlier concern it's not an issue of drm_public vs > drm_private - people simply forget to run make check. make check with all build systems was passing, this was not the problem > As said earlier - if you want this in Intel sure, but don't push it onto others. I will respond to this in the other thread. Lucas De Marchi > > Thanks > Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel