On Thursday, 2018-09-20 18:30:54 +0100, Emil Velikov wrote: > On 20 September 2018 at 16:58, Eric Engestrom <eric.engestrom@xxxxxxxxx> wrote: > > Fixes: 36bb0ea47b71d220b31e "intel: annotate public functions" > > Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > > Cc: Mark Janes <mark.a.janes@xxxxxxxxx> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006 > > Signed-off-by: Eric Engestrom <eric.engestrom@xxxxxxxxx> > > --- > > intel/intel_bufmgr_fake.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > This indicated my earlier concern it's not an issue of drm_public vs > drm_private - people simply forget to run make check. Actually, this is a limitation of the current symbol check system: it only checks that nothing is exported when it shouldn't be, but it doesn't check that what should be exported actually is. My symbols check series fixes that and would've caught these; I really need to find the time to finish it :/ > As said earlier - if you want this in Intel sure, but don't push it onto others. Intel or not isn't the issue here, but I understand your concern. If someone using one of those broken compilers raises a bug, we might have to reconsider and revert it, but for now let's just try to fix it :) > > Thanks > Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
