Hi Noralf. > >+/* Configuration of individual CPU's */ > >+static const struct atmel_lcdc_dc_desc atmel_lcdc_dc_at91sam9261 = { > >+ .guard_time = 1, > >+ .fifo_size = 512, > >+ .min_width = 0, > >+ .min_height = 0, > > Looks like the minimum is always zero, maybe drop it? I kept is at in reality 0 is not an OK value. Will revisit the datasheets and check what they say. As for all the other comments - thanks! I will address them in v2. Currently working on a larger refactoring to address all the feedback. Things becomes simpler which is always good. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel