On Fri, Jul 13, 2018 at 1:44 PM Robin Murphy <robin.murphy@xxxxxxx> wrote: > On 13/07/18 10:50, Sudeep Holla wrote: > >> It doesn't work. This change is breaking the working CLCD on the models. > >> I just tested and CLCD driver returns > >> > > > > It even fails to initialize CLCD on my TC2. > > > > clcd-pl11x 1c1f0000.clcd: PL111 designer 41 rev1 at 0x1c1f0000 > > clcd-pl11x: probe of 1c1f0000.clcd failed with error -2 > > FWIW the same happens on PB-A8; looks like converting to OF graph > bindings falls foul of the "panel-dpi" check in clcdfb_of_get_mode(). That is from the old FB drivers, the defconfig changes in patch 2,3 need to be applied in lockstep with this patch. Then it "should work" (alas I only tested PB-A8 on QEMU, which I modified to hopefully properly model the DVI bridge). Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel