On 09/07/18 08:52, Linus Walleij wrote: > The Versatile Express was submitted with the actual display > bridges unconnected (but defined in the device tree) and > mock "panels" encoded in the device tree node of the PL111 > controller. > > This doesn't even remotely describe the actual Versatile > Express hardware. Exploit the SiI9022 bridge by connecting > the PL111 pads to it, making it use EDID or fallback values > to drive the monitor. > > The also has to use the reserved memory through the > CMA pool rather than by open coding a memory region and > remapping it explicitly in the driver. To achieve this, > a reserved-memory node must exist in the root of the > device tree, so we need to pull that out of the > motherboard .dtsi include files, and push it into each > top-level device tree instead. > > We do the same manouver for all the Versatile Express > boards, taking into account the different location of the > video RAM depending on which chip select is used on > each platform. > > This plays nicely with the new PL111 DRM driver and > follows the standard ways of assigning bridges and > memory pools for graphics. > > Cc: Sudeep Holla <sudeep.holla@xxxxxxx> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > Cc: Liviu Dudau <liviu.dudau@xxxxxxx> > Cc: Mali DP Maintainers <malidp@xxxxxxxxxxxx> > Cc: Robin Murphy <robin.murphy@xxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > ChangeLog v3->v4: > - Fix the ARM and ARM64 shared vexpress-v2m-rc1.dtsi > file address-cells etc so that the ports do not give > DTC warnings anymore. Still get below warnings, not sure if I need to upgrade my DTC ? vexpress-v2f-1xv7-ca53x2.dtb: Warning (graph_child_address): /smb@8000000/motherboard/iofpga@3,00000000/i2c@160000/dvi-transmitter@39/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary rtsm_ve-aemv8a.dtb: Warning (graph_child_address): /smb@8000000/motherboard/iofpga@3,00000000/i2c@160000/dvi-transmitter@39/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary > - Fixed up the CA53 DTS: use the right chip select base > at 0x18000000. I really hate this as it make maintenance difficult, but I don't have good alternative, so I am fine as it is for now :) > - Fixed up the Real-Time Systems Models Virtual Executive > RTSMv8 AEM VE: > - Added the I2C interface (whether implemented in the > emulator or not) It doesn't work. This change is breaking the working CLCD on the models. I just tested and CLCD driver returns > - Fixed the chip select of the memory node to the right > memory base 0x18000000. See, this keeps happening. Anyways I think you can drop RTSM changes if models don't support I2C and DVI. Liviu, As you deal with DRM drivers and I have no knowledge in that domain, I want to hear your feedback or Ack/Review ? -- -- Regards, Sudeep _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
