Hi Lowry, Small drive-by suggestion. Haven't checked if others have pointed it out previously :-\ On 30 May 2018 at 12:23, Lowry Li <lowry.li@xxxxxxx> wrote: > +/** > + * drm_plane_create_blend_mode_property - create a new blend mode property > + * @plane: drm plane > + * @supported_modes: bitmask of supported modes, must include > + * BIT(DRM_MODE_BLEND_PREMULTI) > + * There are two possible blend modes (ignoring 'none'), yet premult must be supported. What if the hardware can do only "coverage"? One-liner explaining why things are as-is would be a great move. HTH Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
