On Thu, May 10, 2018 at 01:59:45PM +0530, Rajesh Yadav wrote:
> Now, since dpu_power_handle manages only bus scaling
> and power enable/disable notifications which are restricted
> to dpu driver, move dpu_power_handle to dpu folder.
>
> Signed-off-by: Rajesh Yadav <ryadav@xxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/Makefile | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 1 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 5 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 2 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 39 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c | 694 +++++++++++++++++++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h | 288 ++++++++++
> drivers/gpu/drm/msm/dpu_power_handle.c | 694 -----------------------
> drivers/gpu/drm/msm/dpu_power_handle.h | 288 ----------
> drivers/gpu/drm/msm/msm_drv.c | 9 -
> drivers/gpu/drm/msm/msm_drv.h | 4 -
> 14 files changed, 1014 insertions(+), 1021 deletions(-)
> create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c
> create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h
> delete mode 100644 drivers/gpu/drm/msm/dpu_power_handle.c
> delete mode 100644 drivers/gpu/drm/msm/dpu_power_handle.h
>
<snip />
> @@ -1863,6 +1863,12 @@ static int dpu_init(struct platform_device *pdev, struct drm_device *dev)
> goto clk_rate_error;
> }
>
> + ret = dpu_power_resource_init(pdev, &dpu_kms->phandle);
> + if (ret) {
> + pr_err("dpu power resource init failed\n");
> + goto power_init_fail;
> + }
> +
> platform_set_drvdata(pdev, dpu_kms);
>
> msm_kms_init(&dpu_kms->base, &kms_funcs);
> @@ -1876,6 +1882,7 @@ static int dpu_init(struct platform_device *pdev, struct drm_device *dev)
>
> return ret;
>
> +power_init_fail:
Nit: No need to add an empty label, just use clk_rate_error above.
With that fixed,
Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> clk_rate_error:
> msm_dss_put_clk(mp->clk_config, mp->num_clk);
> clk_get_error:
<snip />
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
