Hi, On Thu, Mar 29, 2018 at 03:49:08PM +0300, Tomi Valkeinen wrote: > On 29/03/18 15:31, Sebastian Reichel wrote: > > Hi, > > > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: > >> On 29 March 2018 at 11:40, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > >>> omap_framebuffer_get_next_connector() is not used, remove it. > >>> > >> Seems to have been unused for a few years now. > >> Namely since commit 5a35876e2830511cb8110667fc426c6a6165a593 > >> > >> Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > > > I have a pending patch using that function to basically restore the > > functionality from the referenced commit: > > Oh, ok. I'll drop this patch. Thanks. > These was a Klocwork warning for this function, so the easiest fix > was to remove it. > > drivers/gpu/drm/omapdrm/omap_fb.c:326 INFINITE_LOOP.LOCAL (2:Error) Analyze > Infinite loop > * omap_fb.c:326: Entering loop with precondition (from!=0) && > (connector!=0) && from == connector This makes sense to me, since the code initializes connector to from and returns early if from is NULL. > * omap_fb.c:326: condition 0 is always false > * omap_fb.c:326: condition 0 is always false > * omap_fb.c:327: condition connector!=from is always false Looks like list_for_each_entry_from() is not properly understood by the static checker? -- Sebastian
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
