Hi, On Thu, Mar 29, 2018 at 02:24:40PM +0100, Emil Velikov wrote: > On 29 March 2018 at 13:31, Sebastian Reichel > <sebastian.reichel@xxxxxxxxxxxxxxx> wrote: > > Hi, > > > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: > >> On 29 March 2018 at 11:40, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > >> > omap_framebuffer_get_next_connector() is not used, remove it. > >> > > >> Seems to have been unused for a few years now. > >> Namely since commit 5a35876e2830511cb8110667fc426c6a6165a593 > >> > >> Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > > > I have a pending patch using that function to basically restore the > > functionality from the referenced commit: > > > > https://patchwork.kernel.org/patch/10207759/ > > > Hmm I can see very few users of dirtyfb - modesetting, opentegra, > vmgfx, intel (sna only) + the odd IGT test. > > Wondering if that's because it doesn't provide that much of a benefit... > Although it might be because DRM drivers don't fully implement the > functionality ;-) > > Just thinking out loud ^^. Most DRM drivers don't implement DSI's command mode. That's not surprising, if you consider that the typical development boards don't have panels supporting DSI command mode. A quick grep from me suggested, that rockchip supports DSI command mode and they also use dirtyfb. Also the benefit of panel self refresh seems to be big enough, that intel tries to enable it by default since quite some time :) Note, that in mobile phones DSI command mode panels are not as rare as on the development boards. Nokia N950, N9 and Droid 4 each have one of those displays. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
