I noticed a couple of rough edges yesterday as I was running some tests, so here's v2 which fixes them. Most notably, I was experiencing issues when the crtc was being disabled with abandoned events and vblank timeouts. Note that I've bundled the private_obj change into this set since it shares the same theme. It's technically v5, but I'll label it v2 with the rest of the set. PTAL, Sean Sean Paul (6): drm/msm: Use drm_private_obj/state instead of subclassing drm/msm: Refactor complete_commit() to look more the helpers drm/msm: Mark the crtc->state->event consumed drm/msm: Issue queued events when disabling crtc drm/msm: Remove msm_commit/worker, use atomic helper commit drm/msm: Switch to atomic_helper_commit() drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 10 + drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 77 +++---- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 11 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c | 12 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe.c | 28 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 19 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.h | 4 +- drivers/gpu/drm/msm/msm_atomic.c | 223 +-------------------- drivers/gpu/drm/msm/msm_drv.c | 95 ++++++++- drivers/gpu/drm/msm/msm_drv.h | 10 +- drivers/gpu/drm/msm/msm_kms.h | 21 +- 12 files changed, 204 insertions(+), 307 deletions(-) -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel