On Wed, Jan 10, 2018 at 12:39 PM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Wed, Jan 10, 2018 at 12:05 AM, John Stultz <john.stultz@xxxxxxxxxx> wrote: >> From: Rob Herring <robh@xxxxxxxxxx> >> >> EGL, gralloc, and HWC must all have a common definition of fd's and int's >> in native_handle_t to share the fd and width, height, format, etc. of a >> dmabuf. >> >> Move the definition into HWC so we aren't dependent on a specific gralloc >> implementation and so we don't have to create an importer just for >> different native_handle_t layouts. This will allow supporting multiple >> gralloc implementations that conform to this layout. >> >> For now, this is aligned with gbm_gralloc's struct. Once we change >> gbm_gralloc and mesa to point to this copy, we can make modifications to >> the struct. >> >> Change-Id: I0e0e9994c7a13e6c47f00a70d13cd2ef9b1543d3 >> Cc: Marissa Wall <marissaw@xxxxxxxxxx> >> Cc: Sean Paul <seanpaul@xxxxxxxxxx> >> Cc: Dmitry Shmidt <dimitrysh@xxxxxxxxxx> >> Cc: Robert Foss <robert.foss@xxxxxxxxxxxxx> >> Cc: Matt Szczesiak <matt.szczesiak@xxxxxxx> >> Cc: Liviu Dudau <Liviu.Dudau@xxxxxxx> >> Cc: David Hanna <david.hanna11@xxxxxxxxx> >> Signed-off-by: Rob Herring <robh@xxxxxxxxxx> >> [jstultz: This patch is important to be able to build AOSP >> without having to include the gbm_gralloc project.] >> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx> >> --- >> Android.mk | 1 - >> gralloc_drm_handle.h | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 87 insertions(+), 1 deletion(-) >> create mode 100644 gralloc_drm_handle.h > > We have since decided that libdrm is a better place for this. Robert > Foss is working on that. > > But you shouldn't need this at all with your custom importer. Unfortunately the platformdrmgeneric.cpp is part of the build either way, and tries to #include the gralloc_drm_handle.h file (the USE_DRM_GENERIC_IMPORTER conditional is under the includes), which causes build failures. But I'll rework the Andorid.mk logic to conditionally add the platformhisi.cpp or platformdrmgeneric.cpp so this patch can be skipped. thanks -john _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
