On Wed, Dec 20, 2017 at 09:17:07AM +0100, Juergen Gross wrote: > On 20/12/17 00:27, Dongwon Kim wrote: > > I forgot to include this brief information about this patch series. > > > > This patch series contains the implementation of a new device driver, > > hyper_dmabuf, which provides a method for DMA-BUF sharing across > > different OSes running on the same virtual OS platform powered by > > a hypervisor. > > Some general remarks regarding this series: > > You are starting the whole driver in drivers/xen/ and in the last patch > you move it over to drivers/dma-buf/. Why don't you use drivers/dma-buf/ > from the beginning? The same applies to e.g. patch 22 changing the > license. Please make it easier for the reviewers by not letting us > review the development history of your work. Yeah, I tried to clean up our developement history but because of dependencies among patches, I couldn't make those things clear in the first place. I will try to clean things up further. > > Please run ./scripts/checkpatch.pl on each patch and correct the issues > it is reporting. At the first glance I've seen several style problems > which I won't comment until the next round. hmm.. I ran the script only on the final version and try to fix all the issues after that. If it's required for individual patches, I will clean up every patch once again. > > Please add the maintainers as Cc:, not only the related mailing lists. > As you seem to aim supporting other hypervisors than Xen you might want > to add virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx as well. Ok, thanks! > > > Juergen _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
