Quoting Igor Gnatenko (2018-01-04 13:43:51) > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On Thu, 2018-01-04 at 10:28 -0800, Dylan Baker wrote: > > This patch adds a complete meson build system, including tests and > > install. It has the necessary hooks to allow it be used as a subproject > > for other meson based builds such as mesa. > > Builds fine on all architectures supported by Fedora, boots fine on my laptop > (x86_64). > > All nitpicks are inline. > > > Signed-off-by: Dylan Baker <dylan.c.baker@xxxxxxxxx> > > Reviewed-and-tested-by: Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> > > > diff --git a/meson_options.txt b/meson_options.txt > > new file mode 100644 > > index 0000000..08c2ccd > > --- /dev/null > > +++ b/meson_options.txt > > @@ -0,0 +1,143 @@ > > [...] > > +option( > > + 'intel', > > + type : 'combo', > > + value : 'auto', > > + choices : ['true', 'false', 'auto'], > > + description : '''Enable support for Intel's KMS API.''', > > Any reason to use `'''` here and there? to avoid escaping the ' in "Intel's". But I can change it if you prefer. > > > [...] > > +option( > > + 'man-pages', > > + type : 'combo', > > + value : 'auto', > > + choices : ['true', 'false', 'auto'], > > + description : 'Enable manpage generation and install.', > > "installation". > > > [...] > > +option( > > + 'valgrind', > > + type : 'combo', > > + value : 'auto', > > + choices : ['true', 'false', 'auto'], > > + description : 'build libdrm with valgrind support', > > "Build". And fullstop at the end of sentence. > - -- > - -Igor Gnatenko > -----BEGIN PGP SIGNATURE----- > > iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlpOoBcACgkQaVcUvRu8 > X0yF9w//cgaMVkU4xTKegRJY4uuzTE3MQvMmaCoA8ivBaCWPuoX3ozlwsAgZZXaZ > Vo83tZ0u80cjgoSG4I/JcNp3UhsxtGgqcrqqcof/SGn+YS43eFKPL57dowwQ5qk3 > ccAUgHtAdQXuCJFaQFsTISSEj1X07RA04mIMe7QZFh7AHsKmv+ctaTUO7uJsXJzi > aX7Z9rntTCnXvzZy7Y56XPCleXfi+yDzQPdDopZAEdLYT8hYUvebo6JGQUpg8iNd > YuvZsbkrpyV1uMY/2feSJ3Ns4ZTAj3I4F41Xbb7CqZt/BX60EnkZJXog4RSbdlri > cxMX7gPkrOXxNJbllmdN0nPdBP/atViRY7dDkE4Lv4YrmwL8oT4Mjfyb/TeINT2X > 6NltSgc8+zSvQSkjWyKHzQ3ZQCQHIAheG+V2Cvnc1NIfX06AV9USRsSRzBMza+gW > cWNT2g/M0jjmLTVEoLR8MSLXAB9gfsBdRDEnvqEsZCqDh1idW1Ttuk3m/h3+BT8i > GMyCrswVgKLI7gBbdVFdLDarEIVtTJlYvPkGXxRyOzv1r5dM/MMmeay7P3WD+liE > CLF9nRVrekQA7Mh4Y61RSyFAntzBokNKL+FrSzSuseNtgYAM3Es0JgY1ndsczvVX > zUqULC0AEAEwmAIQmDlYFG+ut8nIvmk6aWHHlvLwUHgiDD+MEc4= > =dAKV > -----END PGP SIGNATURE----- >
Attachment:
signature.asc
Description: signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
