I got your point . I can push follow up patch with document change and code update as discussed here. Keeping that I think this patch should be ok to land? Thanks, Deepak -----Original Message----- From: Emil Velikov [mailto:emil.l.velikov@xxxxxxxxx] Sent: Thursday, November 16, 2017 7:40 AM To: Sharma, Deepak <Deepak.Sharma@xxxxxxx> Cc: ML dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Stéphane Marchesin <marcheu@xxxxxxxxxxxx>; intel-gfx-trybot@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH] drm/vgem: Fix vgem_init to get drm device avaliable. On 15 November 2017 at 21:25, Sharma, Deepak <Deepak.Sharma@xxxxxxx> wrote: >> >> I'd still recommend updating the two functions' documentation, ideally coupled with enforcing for *parent to be non NULL. >> Could be code as follow-up though. >> > If I got it correctly you are referring "Note that for purely virtual devices @parent can be NULL" for said two functions. > I think changes might be required if it was "should/must be NULL"? Since you're changing the behaviour: The statement "Note that for purely virtual devices @parent can be NULL" is never true and should be dropped. Additionally, you want to update the functions to error out when parent is NULL since it indicates a driver bug. For the drm_dev_set_unique hunk one can drop the comment (it's NA) and simplify to: ret = drm_dev_set_unique(dev, dev_name(parent)); As mentioned before - it can be code as follow-up. >> >> Most of which use i915 <> vgem. If you don't have the HW to test, one can use the Intel GFX trybot. >> Just keep [1] in the To/CC list and you'll get a report with the results. >> > > Thanks. I have added Intel GFX trybot in CC, that should be sufficient or I need to send patch again using git send-mail? > Right, should have been clearer - the actual patches should be send/cc'd. Otherwise one has know way of retrieving (and thus testing) the patch ;-) HTH Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
