-----Original Message----- From: Emil Velikov [mailto:emil.l.velikov@xxxxxxxxx] Sent: Monday, October 30, 2017 6:23 AM To: Sharma, Deepak <Deepak.Sharma@xxxxxxx> Cc: ML dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Stéphane Marchesin <marcheu@xxxxxxxxxxxx> Subject: Re: [PATCH] drm/vgem: Fix vgem_init to get drm device avaliable. On 26 October 2017 at 00:02, Deepak Sharma <Deepak.Sharma@xxxxxxx> wrote: > From: Deepak Sharma <deepak.sharma@xxxxxxx> > > Modify vgem_init to take platform dev as parent in drm_dev_init. > This will make drm device available at "/sys/devices/platform/vgem" > in x86 chromebook. > Shouldn't one update the drm_dev_init/drm_dev_alloc documentation while doing this? But more importantly, this will change the "unique" string (see drm_dev_set_unique). Sorry I did not get your comment about updating drm_dev_init/drm_dev_alloc documentation for this change. Do you see any issue if this "unique string " is changed The topic around it rather convoluted and messy, so please check this change doesn't cause subtle regressions. There's a doc hunk in drm_ioctl.c to begin with, plus userspace such as IGT [1] might rely on the current behaviour. HTH Emil [1] https://cgit.freedesktop.org/drm/igt-gpu-tools/ I did run vgem test from IGT to check for regression , do you suspect regression in other tests ? Thanks, Deepak _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
