On Mon, Nov 13, 2017 at 11:31:28PM +0100, Noralf Trønnes wrote: > > Den 13.11.2017 23.17, skrev Chris Wilson: > > Quoting Noralf Trønnes (2017-11-13 22:12:06) > > > Den 13.11.2017 22.33, skrev Chris Wilson: > > > > Quoting Noralf Trønnes (2017-11-13 19:54:43) > > > > > Den 11.11.2017 19.55, skrev Chris Wilson: > > > > > > Quoting Noralf Trønnes (2017-11-07 19:13:40) > > > > > > > Add debugfs file that dumps info about the framebuffers and its planes. > > > > > > > Also dump info about any connected gem object(s). > > > > > > This isn't too hot for non-modesetting drm drivers. > > > > Just to be clear; this is currently on fire in i915's CI. As > > > > framebuffer-info is installed for vgem and vgem hasn't initialised any > > > > of the data structs being inspected... > > > Ok, so I have broken vgem :-( > > > > > > drm_framebuffer_info() takes dev->mode_config.fb_lock which hasn't been > > > initialized because vgem doesn't call drm_mode_config_init(). > > > drm_mode_config_init() in addition to initializing various thing also > > > calls drm_mode_create_standard_properties(). > > > > > > Can we call drm_mode_config_init() in vgem or is this a no-go because of > > > the properties? Do you see a solution to this? > > My quick fix idea was a drm_core_check_feature(dev, DRIVER_MODESET) > > around the drm_framebuffer_debugfs_init(). > > Ah, yes, thank you! > That sounds like a good idea. I will create a patch. Yeah we need that check, same way we have it in all the ioctls. Sorry for not spotting this, and yes we need our CI checking dri-devel patches, but just not there yet :-/ -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
