On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt <eric@xxxxxxxxxx> wrote: > Stefan Schake <stschake@xxxxxxxxx> writes: > >> The overflow mem work callback vc4_overflow_mem_work reenables its >> associated interrupt upon completion. To ensure all interrupts are disabled >> when we return from vc4_irq_uninstall, we need to disable it again if >> cancel_work_sync indicated pending work. > > Is there a reason we need the interrupts disabled at the V3D level while > we have the IRQ disabled at the irqchip level? Once we re-enable at the > irqchip, we immediately V3D_WRITE(V3D_INTENA, V3D_DRIVER_IRQS) anyway. irqchip will mask it in the ARM interrupt controller, so we will certainly never see an interrupt. I'm not sure on the exact guarantees V3D_INTENA and V3D_INTCTL make - does the state in INTENA affect if V3D will signal an interrupt in INTCTL? We're not currently clearing the latter in postinstall. >From a practical perspective, we're not doing anything in between uninstall and postinstall that would trigger the interrupt. So in that sense it's certainly superfluous. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
