Re: [PATCH hwc] Android: add CleanSpec.mk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2017-11-03 20:35 GMT+08:00 Rob Herring <robh@xxxxxxxxxx>:
> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang <cwhuang@xxxxxxxxxxxxxxx> wrote:
>> The file contains rules that are executed on incremental builds.
>> Since commit 4f7dc9b6 the library was moved to /vendor so
>> the old file must be removed.
>>
>> Signed-off-by: Chih-Wei Huang <cwhuang@xxxxxxxxxxxx>
>> ---
>>  CleanSpec.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>  create mode 100644 CleanSpec.mk
>>
>> diff --git a/CleanSpec.mk b/CleanSpec.mk
>> new file mode 100644
>> index 0000000..99dcecd
>> --- /dev/null
>> +++ b/CleanSpec.mk
>> @@ -0,0 +1 @@
>> +$(call add-clean-step, rm -rf $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)
>
> Seems a bit silly to add forever an explicit file to clean for a
> transient problem.

The problem is people usually won't notice
the libraries have been moved to /vendor.
In an incremental build the old files still
exist in /system that may cause issues.

It's necessary unless you have a better idea
to tell people "hey, you need to do a clean build".


-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux